Skip to content

KAFKA-9490: Fix generics for Grouped#8028

Merged
mjsax merged 1 commit into
apache:trunkfrom
mjsax:kafka-9490-fix-grouped-generics
Feb 4, 2020
Merged

KAFKA-9490: Fix generics for Grouped#8028
mjsax merged 1 commit into
apache:trunkfrom
mjsax:kafka-9490-fix-grouped-generics

Conversation

@mjsax

@mjsax mjsax commented Jan 31, 2020

Copy link
Copy Markdown
Member

Call for review @guozhangwang @vvcephei

@mjsax mjsax added the streams label Jan 31, 2020

@vvcephei vvcephei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @mjsax!

@mjsax

mjsax commented Feb 1, 2020

Copy link
Copy Markdown
Member Author

Java 11:

kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup
org.apache.kafka.streams.kstream.internals.KStreamImplTest.shouldSupportTriggerMaterializedWithKTableFromKStream

For the second failure, the error is:

java.lang.ClassCastException: class java.lang.Integer cannot be cast to class java.lang.String (java.lang.Integer and java.lang.String are in module java.base of loader 'bootstrap')
	at org.apache.kafka.streams.kstream.internals.KStreamImplTest.lambda$asMap$229(KStreamImplTest.java:2960)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at org.apache.kafka.streams.kstream.internals.KStreamImplTest.asMap(KStreamImplTest.java:2960)
	at org.apache.kafka.streams.kstream.internals.KStreamImplTest.

This is a new test that was merged recently via #7989 (but the build was green; also re-run the test locally and it passed) -- we also have a follow up PR #8027 (in case there is a real issue, we can fix it there -- did not create a ticket for that reason).

Java 8 timed out.

Retest this please.

@mjsax

mjsax commented Feb 2, 2020

Copy link
Copy Markdown
Member Author

Java 11:

kafka.admin.ReassignPartitionsClusterTest.shouldListReassignmentsTriggeredByZk
kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsExportImportPlan
kafka.api.SaslSslConsumerTest.testCoordinatorFailover

Java 8:

kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsAllTopicsAllGroups
kafka.api.SaslOAuthBearerSslEndToEndAuthorizationTest.testProduceConsumeTopicAutoCreateTopicCreateAcl
kafka.api.SslAdminIntegrationTest.testSynchronousAuthorizerAclUpdatesBlockRequestThreads

Retest this please.

@mjsax

mjsax commented Feb 4, 2020

Copy link
Copy Markdown
Member Author

Java 8:

org.apache.kafka.clients.admin.KafkaAdminClientTest.testDefaultApiTimeoutOverride
kafka.admin.DescribeConsumerGroupTest.testDescribeGroupMembersWithShortInitializationTimeout

Java 11:

kafka.admin.DescribeConsumerGroupTest.testDescribeGroupWithShortInitializationTimeout
kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsExportImportPlan

Every test passed in at least one test run. Merging.

@mjsax
mjsax merged commit 8bb962d into apache:trunk Feb 4, 2020
ijuma added a commit to confluentinc/kafka that referenced this pull request Feb 4, 2020
Conflicts related to version bump in AK, replaced
2.6 with 6.0:
* gradle.properties
* __init__.py
* version.py

* apache-github/trunk:
  KAFKA-9490: Fix generics for Grouped (apache#8028)
  Bump trunk to 2.6.0-SNAPSHOT (apache#8026)
  KAFKA-9027, KAFKA-9028: Convert create/delete acls requests/response to use generated protocol (apache#7725)
  MINOR: Refactor CheckpointFile to improve testability (apache#7391)
  MINOR: updated documentation where RocksDBStore was being used as the sample class for byte[] versus Bytes examples (apache#5884)
@mjsax
mjsax deleted the kafka-9490-fix-grouped-generics branch February 5, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants