HOTFIX: fix even/odd rows for upgrade.from config - #7837
Merged
bbejeck merged 1 commit intoDec 23, 2019
Conversation
bbejeck
approved these changes
Dec 16, 2019
bbejeck
left a comment
bbejeck
left a comment
Member
There was a problem hiding this comment.
LGTM. @ableegoldman did you render this locally to confirm?
Member
Author
|
No...but I noticed in another PR that several other configs also break this even/odd pattern, yet as far as we could tell there are no visible effects. |
Member
|
Merged #7837 into trunk. |
bbejeck
pushed a commit
that referenced
this pull request
Dec 23, 2019
Minor followup to #7825, should be cherry-picked to 2.4 Reviewers: Bill Bejeck <bbejeck@gmail.com>
Member
|
cherry-picked to 2.4 |
qq619618919
pushed a commit
to qq619618919/kafka
that referenced
this pull request
May 12, 2020
Minor followup to apache#7825, should be cherry-picked to 2.4 Reviewers: Bill Bejeck <bbejeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor followup to #7825, should be cherry-picked to 2.4