MINOR: add UPGRADE_FROM to 2.4 config docs - #7825
Merged
guozhangwang merged 1 commit intoDec 13, 2019
Merged
Conversation
Member
Author
ableegoldman
changed the title
ableegoldman
changed the title
guozhangwang
pushed a commit
that referenced
this pull request
Dec 13, 2019
Reviewers: Guozhang Wang <wangguoz@gmail.com>
ableegoldman
changed the title
omkreddy
reviewed
Dec 14, 2019
| <td colspan="2">Timestamp extractor class that implements the <code class="docutils literal"><span class="pre">TimestampExtractor</span></code> interface.</td> | ||
| <td>See <a class="reference internal" href="#streams-developer-guide-timestamp-extractor"><span class="std std-ref">Timestamp Extractor</span></a></td> | ||
| </tr> | ||
| <tr class="row-odd"><td>upgrade.from</td> |
Contributor
There was a problem hiding this comment.
@ableegoldman minor nit: row-odd => row-even.
also need to update below rows
Member
Author
There was a problem hiding this comment.
We'll have to cherry-pick this PR to 2.4 first, then we can merge/cherry-pick that fix on top of it
bbejeck
pushed a commit
that referenced
this pull request
Dec 23, 2019
Minor followup to #7825, should be cherry-picked to 2.4 Reviewers: Bill Bejeck <bbejeck@gmail.com>
bbejeck
pushed a commit
that referenced
this pull request
Dec 23, 2019
Minor followup to #7825, should be cherry-picked to 2.4 Reviewers: Bill Bejeck <bbejeck@gmail.com>
qq619618919
pushed a commit
to qq619618919/kafka
that referenced
this pull request
May 12, 2020
Reviewers: Guozhang Wang <wangguoz@gmail.com>
qq619618919
pushed a commit
to qq619618919/kafka
that referenced
this pull request
May 12, 2020
Minor followup to apache#7825, should be cherry-picked to 2.4 Reviewers: Bill Bejeck <bbejeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This config is among those missing from the "Configuring a Streams Application" docs, and since it is once again required for safe upgrade in 2.4 we should really make sure it's included.
This should only be cherry-picked to 2.4 since it references the new version (2.4)
Separate PR for the 2.0 - 2.3 docs: #7831