Skip to content

MINOR: Reset timer when all the buffer is drained and empty #7573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 1 commit into from
Oct 22, 2019
+50 −1
Merged

MINOR: Reset timer when all the buffer is drained and empty #7573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,9 @@ boolean isProcessable(final long now) {
return false;
}
} else {
// there's no data in any of the topics; we should reset the enforced
// processing timer
idleStartTime = RecordQueue.UNKNOWN;
return false;
}
}
Expand Down
48 changes: 47 additions & 1 deletion streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ public void shouldBeProcessableIfWaitedForTooLong() {

assertFalse(task.isProcessable(time.milliseconds()));

assertFalse(task.isProcessable(time.milliseconds() + 50L));
assertFalse(task.isProcessable(time.milliseconds() + 99L));

assertTrue(task.isProcessable(time.milliseconds() + 100L));
assertEquals(1.0, metrics.metric(enforcedProcessMetric).metricValue());
Expand All @@ -875,6 +875,52 @@ public void shouldBeProcessableIfWaitedForTooLong() {
assertEquals(3.0, metrics.metric(enforcedProcessMetric).metricValue());
}

@Test
public void shouldNotBeProcessableIfNoDataAvailble() {
task = createStatelessTask(createConfig(false), StreamsConfig.METRICS_LATEST);
task.initializeStateStores();
task.initializeTopology();

final MetricName enforcedProcessMetric = metrics.metricName(
"enforced-processing-total",
"stream-task-metrics",
mkMap(mkEntry("thread-id", Thread.currentThread().getName()), mkEntry("task-id", taskId00.toString()))
);

assertFalse(task.isProcessable(0L));
assertEquals(0.0, metrics.metric(enforcedProcessMetric).metricValue());

final byte[] bytes = ByteBuffer.allocate(4).putInt(1).array();

task.addRecords(partition1, Collections.singleton(new ConsumerRecord<>(topic1, 1, 0, bytes, bytes)));

assertFalse(task.isProcessable(time.milliseconds()));

assertFalse(task.isProcessable(time.milliseconds() + 99L));

assertTrue(task.isProcessable(time.milliseconds() + 100L));
assertEquals(1.0, metrics.metric(enforcedProcessMetric).metricValue());

// once the buffer is drained and no new records coming, the timer should be reset
task.process();

assertFalse(task.isProcessable(time.milliseconds() + 110L));
assertEquals(1.0, metrics.metric(enforcedProcessMetric).metricValue());

// check that after time is reset, we only falls into enforced processing after the
// whole timeout has elapsed again
task.addRecords(partition1, Collections.singleton(new ConsumerRecord<>(topic1, 1, 0, bytes, bytes)));

assertFalse(task.isProcessable(time.milliseconds() + 150L));
assertEquals(1.0, metrics.metric(enforcedProcessMetric).metricValue());

assertFalse(task.isProcessable(time.milliseconds() + 249L));
assertEquals(1.0, metrics.metric(enforcedProcessMetric).metricValue());

assertTrue(task.isProcessable(time.milliseconds() + 250L));
assertEquals(2.0, metrics.metric(enforcedProcessMetric).metricValue());
}


@Test
public void shouldPunctuateSystemTimeWhenIntervalElapsed() {
Expand Down