MINOR: Reset timer when all the buffer is drained and empty - #7573
Merged
guozhangwang merged 1 commit intoOct 22, 2019
Merged
Conversation
abbccdda
reviewed
Oct 21, 2019
abbccdda
left a comment
abbccdda
left a comment
There was a problem hiding this comment.
To me the test numbers are kind of arbitrary. Could we define certain time point as constant, like 100L and 250L?
Contributor
Author
We set the max.task.idle to 100 and that's why we tested 99 v.s. 100 and 249 v.s. 250 etc for that config. I think it's kind of an overkill to define them as constant though. |
bbejeck
approved these changes
Oct 22, 2019
javierholguera
approved these changes
Oct 22, 2019
guozhangwang
added a commit
that referenced
this pull request
Dec 16, 2019
For scenarios where the incoming traffic of all input partitions are small, there's a pitfall that the enforced processing timer is not reset after we have enforce processed ALL records. The fix itself is pretty simple: we just reset the timer when there's no buffered records. Reviewers: Javier Holguera <javier.holguera@gmail.com>, Boyang Chen <boyang@confluent.io>, Bill Bejeck <bill@confluent.io>
guozhangwang
added a commit
that referenced
this pull request
Dec 20, 2019
For scenarios where the incoming traffic of all input partitions are small, there's a pitfall that the enforced processing timer is not reset after we have enforce processed ALL records. The fix itself is pretty simple: we just reset the timer when there's no buffered records. Reviewers: Javier Holguera <javier.holguera@gmail.com>, Boyang Chen <boyang@confluent.io>, Bill Bejeck <bill@confluent.io> fix unit test
qq619618919
pushed a commit
to qq619618919/kafka
that referenced
this pull request
May 12, 2020
) For scenarios where the incoming traffic of all input partitions are small, there's a pitfall that the enforced processing timer is not reset after we have enforce processed ALL records. The fix itself is pretty simple: we just reset the timer when there's no buffered records. Reviewers: Javier Holguera <javier.holguera@gmail.com>, Boyang Chen <boyang@confluent.io>, Bill Bejeck <bill@confluent.io> fix unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For scenarios where the incoming traffic of all input partitions are small, there's a pitfall that the enforced processing timer is not reset after we have enforce processed ALL records. The fix itself is pretty simple: we just reset the timer when there's no buffered records.
Committer Checklist (excluded from commit message)