Minor: Rename methods to add metrics to sensor in StreamsMetricsImpl#7161
Merged
Merged
Conversation
Member
Author
ableegoldman
approved these changes
Aug 5, 2019
ableegoldman
left a comment
ableegoldman
left a comment
Member
There was a problem hiding this comment.
LGTM, just curious though what is the motivation here? IS it just to clarify that these methods are adding to a sensor, or will we be adding some other methods later that necessitate this?
guozhangwang
approved these changes
Aug 5, 2019
guozhangwang
left a comment
guozhangwang
left a comment
Contributor
There was a problem hiding this comment.
This is from a previous PR's conversation to make the API naming consistency.
Contributor
|
retest this please |
Member
Author
|
In Java 11 and Scala 2.13 the following tests failed In Java 8 the following tests failed Retest this, please |
3 tasks
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Aug 8, 2019
The avro upgrade was needed to fix the following error during ':support-metrics-client:generateAvro': Caused by: org.apache.velocity.exception.MethodInvocationException: Variable $velocityCount has not been set at /org/apache/avro/compiler/specific/templates/java/classic/record.vm[line 82, column 150] Conflicts: * gradle.properties -> trivial fix, `scalaVersion` is next to `version`, which is different in ccs kafka * gradle/dependencies.gradle -> reduce divergence with apache kafka by using `httpclient` instead of `httpcomponents` from the `versions` array. Remove unused `httpmime` and `httpcomponents` from said array. * apache-github/trunk: MINOR: Update dependencies for Kafka 2.4 (apache#7126) KAFKA-8599: Use automatic RPC generation in ExpireDelegationToken MINOR: Upgrade jackson-databind to 2.9.9.3 (apache#7125) MINOR: some small style fixes to RoundRobinPartitioner KAFKA-8736: Streams performance improvement, use isEmpty() rather than size() == 0 (apache#7164) Minor: Refactor methods to add metrics to sensor in `StreamsMetricsImpl` (apache#7161)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames method names in
StreamsMetricsImplto make them consistent.Committer Checklist (excluded from commit message)