MINOR: Upgrade jackson-databind to 2.9.9.3#7125
Merged
Merged
Conversation
Member
Author
|
retest this please |
1 similar comment
Member
|
retest this please |
arvindth
reviewed
Jul 31, 2019
Contributor
There was a problem hiding this comment.
Question on this addition: Instead of hardcoding this version here, perhaps it might be nicer to add a section after this array definition:
# In most cases we want the jackson-databind version to match jackson, unless
# there's an updated micropatch
# versions["jacksonDatabind"] = versions["jackson"]
versions["jacksonDatabind"] = "2.9.9.2"
That way during the next upgrade to jackson, we mirror the versions, and future jackson upgrades only need to update the main version.
Member
Author
There was a problem hiding this comment.
I think that's more likely to cause issues as the two jackson library versions are not near each other.
2.9.9.1 and 2.9.9.2 include security fixes.
ijuma
force-pushed
the
jackson-databind-2.9.9.2
branch
from
August 6, 2019 02:54
aa34959 to
e787bec
Compare
ijuma
changed the title
Member
Author
|
@omkreddy Let me know if the updated version looks good. |
Member
Author
|
retest this please |
Contributor
|
@ijuma upgrade to jackson-databind 2.9.9.3 LGTM. thanks. |
Member
Author
|
Both JDK 11 builds passed, JDK 8 had an unrelated timeout. Merging to master and cherry-picking to 2.3 and 2.2 branches. |
ijuma
added a commit
that referenced
this pull request
Aug 7, 2019
2.9.9.1 and 2.9.9.2 include security fixes while 2.9.9.3 fixes a regression introduced in 2.9.9.2. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
ijuma
added a commit
that referenced
this pull request
Aug 7, 2019
2.9.9.1 and 2.9.9.2 include security fixes while 2.9.9.3 fixes a regression introduced in 2.9.9.2. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
3 tasks
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Aug 8, 2019
The avro upgrade was needed to fix the following error during ':support-metrics-client:generateAvro': Caused by: org.apache.velocity.exception.MethodInvocationException: Variable $velocityCount has not been set at /org/apache/avro/compiler/specific/templates/java/classic/record.vm[line 82, column 150] Conflicts: * gradle.properties -> trivial fix, `scalaVersion` is next to `version`, which is different in ccs kafka * gradle/dependencies.gradle -> reduce divergence with apache kafka by using `httpclient` instead of `httpcomponents` from the `versions` array. Remove unused `httpmime` and `httpcomponents` from said array. * apache-github/trunk: MINOR: Update dependencies for Kafka 2.4 (apache#7126) KAFKA-8599: Use automatic RPC generation in ExpireDelegationToken MINOR: Upgrade jackson-databind to 2.9.9.3 (apache#7125) MINOR: some small style fixes to RoundRobinPartitioner KAFKA-8736: Streams performance improvement, use isEmpty() rather than size() == 0 (apache#7164) Minor: Refactor methods to add metrics to sensor in `StreamsMetricsImpl` (apache#7161)
xiowu0
pushed a commit
to linkedin/kafka
that referenced
this pull request
Aug 22, 2019
…apache#7125) TICKET = LI_DESCRIPTION = EXIT_CRITERIA = HASH [8e87041] ORIGINAL_DESCRIPTION = 2.9.9.1 and 2.9.9.2 include security fixes while 2.9.9.3 fixes a regression introduced in 2.9.9.2. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com> (cherry picked from commit 8e87041)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.9.9.1 and 2.9.9.2 include security fixes while 2.9.9.3 fixes a regression introduced
in 2.9.9.2.
Committer Checklist (excluded from commit message)