Skip to content

KAFKA-8430: unit test to make sure null group.id and valid group.instance.id are valid combo #6830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 2 commits into from
May 28, 2019
Merged

KAFKA-8430: unit test to make sure null group.id and valid group.instance.id are valid combo #6830

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30bca4a
unit test
May 28, 2019
88d9e4f
address comments
May 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,18 @@ public void testInvalidSocketReceiveBufferSize() {
new KafkaConsumer<>(config, new ByteArrayDeserializer(), new ByteArrayDeserializer());
}

@Test
public void testInitSuccessWithDefaultNullGroupIdAndValidGroupInstanceId() {

@mjsax mjsax May 28, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: shouldIgnoreGroupInstanceIdForEmptyGroupId

Map<String, Object> config = new HashMap<>();
config.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:9999");
config.put(ConsumerConfig.SEND_BUFFER_CONFIG, Selectable.USE_DEFAULT_BUFFER_SIZE);
config.put(ConsumerConfig.RECEIVE_BUFFER_CONFIG, Selectable.USE_DEFAULT_BUFFER_SIZE);

@mjsax mjsax May 28, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to set SEND_BUFFER_CONFIG and RECEIVE_BUFFER_CONFIG ?

@abbccdda abbccdda May 28, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we don't lol

config.put(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG, "instance_id");
KafkaConsumer<byte[], byte[]> consumer = new KafkaConsumer<>(
config, new ByteArrayDeserializer(), new ByteArrayDeserializer());
consumer.close();
}

@Test
public void testSubscription() {
KafkaConsumer<byte[], byte[]> consumer = newConsumer(groupId);
Expand Down