KAFKA-8430: unit test to make sure null group.id and valid group.instance.id are valid combo#6830
Merged
Merged
Conversation
Author
|
@mjsax @guozhangwang FYI |
mjsax
reviewed
May 28, 2019
| } | ||
|
|
||
| @Test | ||
| public void testInitSuccessWithDefaultNullGroupIdAndValidGroupInstanceId() { |
Member
There was a problem hiding this comment.
nit: shouldIgnoreGroupInstanceIdForEmptyGroupId
| Map<String, Object> config = new HashMap<>(); | ||
| config.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:9999"); | ||
| config.put(ConsumerConfig.SEND_BUFFER_CONFIG, Selectable.USE_DEFAULT_BUFFER_SIZE); | ||
| config.put(ConsumerConfig.RECEIVE_BUFFER_CONFIG, Selectable.USE_DEFAULT_BUFFER_SIZE); |
Member
There was a problem hiding this comment.
Why do we need to set SEND_BUFFER_CONFIG and RECEIVE_BUFFER_CONFIG ?
guozhangwang
left a comment
guozhangwang
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Waiting for green builds.
Author
|
Retest this please |
guozhangwang
pushed a commit
that referenced
this pull request
May 28, 2019
…nstance.id` are valid combo (#6830) As title suggests, this unit test is just a double check. No need to push in 2.3 Reviewers: Guozhang Wang <wangguoz@gmail.com>, Matthias J. Sax <mjsax@apache.org>
Contributor
|
Cherry-picked to 2.3 as well. |
haidangdam
pushed a commit
to haidangdam/kafka
that referenced
this pull request
May 29, 2019
…nstance.id` are valid combo (apache#6830) As title suggests, this unit test is just a double check. No need to push in 2.3 Reviewers: Guozhang Wang <wangguoz@gmail.com>, Matthias J. Sax <mjsax@apache.org>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…nstance.id` are valid combo (apache#6830) As title suggests, this unit test is just a double check. No need to push in 2.3 Reviewers: Guozhang Wang <wangguoz@gmail.com>, Matthias J. Sax <mjsax@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as title suggests, this unit test is just a double check. No need to push in 2.3
Committer Checklist (excluded from commit message)