Docs: updated names for deprecated streams constants#6466
Merged
mjsax merged 2 commits intoMar 19, 2019
Conversation
Signed-off-by: Victoria Bialas <vicky@confluent.io>
Member
|
@londoncalling! Same comment as in kafka-site/191 -- can we update |
Contributor
Author
|
Hi Matthias .. sure I can make all those updates. Will get to it tonight .
…On Mon, Mar 18, 2019 at 5:24 PM Matthias J. Sax ***@***.***> wrote:
@londoncalling <https://github.com/londoncalling>! Come comment as in
kafka-site/191 -- can we update timestamp.extractore to
default.timestamp.extractor, too?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6466 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALHuA5SgkKfmPOhKCU4ZFaOlj8oogOECks5vYC5VgaJpZM4b601X>
.
|
Signed-off-by: Victoria Bialas <vicky@confluent.io>
Contributor
Author
|
@mjsax , on the most recent commit, I replaced (Same as for apache/kafka-site#191, only on that one multiple versions updated) If all is good, feel free to merge, or let me know if you need anything else! |
Member
|
Thanks a lot for the PR @londoncalling! |
mjsax
pushed a commit
that referenced
this pull request
Mar 19, 2019
* updated names for deprecated streams constants * add DEFAULT_TIMESTAMP_EXTRACTOR_CLASS_CONFIG in place of deprecated Reviewers: Jim Galasyn <jim.galasyn@confluent.io>, Matthias J. Sax <matthias@confluent.io>
mjsax
pushed a commit
that referenced
this pull request
Mar 19, 2019
* updated names for deprecated streams constants * add DEFAULT_TIMESTAMP_EXTRACTOR_CLASS_CONFIG in place of deprecated Reviewers: Jim Galasyn <jim.galasyn@confluent.io>, Matthias J. Sax <matthias@confluent.io>
Member
|
Merged to Might be worth to do a new PR for |
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* apache/trunk: (23 commits) KAFKA-7986: Distinguish logging from different ZooKeeperClient instances (apache#6493) KAFKA-8102: Add an interval-based Trogdor transaction generator (apache#6444) MINOR: Fix misspelling in protocol documentation KAFKA-8150: Fix bugs in handling null arrays in generated RPC code (apache#6489) KAFKA-8014: Extend Connect integration tests to add and remove workers dynamically (apache#6342) MINOR: Remove line for testing repartition topic name (apache#6488) MINOR: add MacOS requirement to Streams docs MINOR: fix message protocol help text for ElectPreferredLeadersResult (apache#6479) MINOR: list-topics should not require topic param MINOR: Clean up ThreadCacheTest (apache#6485) MINOR: Avoid unnecessary collection copy in MetadataCache (apache#6397) KAFKA-8142: Fix NPE for nulls in Headers (apache#6484) KAFKA-7243: Add unit integration tests to validate metrics in Kafka Streams (apache#6080) MINOR: Add verification step for Streams archetype to Jenkins build (apache#6431) KAFKA-7819: Improve RoundTripWorker (apache#6187) KAFKA-7989: RequestQuotaTest should wait for quota config change before running tests (apache#6482) KAFKA-8098: Fix Flaky Test testConsumerGroups KAFKA-6958: Add new NamedOperation interface to enforce consistency in naming operations (apache#6409) MINOR: capture result timestamps in Kafka Streams DSL tests (apache#6447) MINOR: updated names for deprecated streams constants (apache#6466) ...
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
* updated names for deprecated streams constants * add DEFAULT_TIMESTAMP_EXTRACTOR_CLASS_CONFIG in place of deprecated Reviewers: Jim Galasyn <jim.galasyn@confluent.io>, Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs update: Streams Developer Guide
KEY_SERDE_CLASS_CONFIGandVALUE_KEY_SERDE_CLASS_CONFIGwere deprecated in https://kafka.apache.org/11/javadoc/deprecated-list.html and replaced byDEFAULT_KEY_SERDE_CLASS_CONFIGandDEFAULT_VALUE_KEY_SERDE_CLASS_CONFIGReplaced deprecated constants in example code with up-to-date ones in
11and all subsequent versionsRelated
PR on
apache/kafka-site: apache/kafka-site#191cc, please review/merge:
Signed-off-by: Victoria Bialas vicky@confluent.io