Skip to content

MINOR: updated deprecated streams constants#191

Merged
mjsax merged 2 commits into
apache:asf-sitefrom
londoncalling:Kafka-deprecated-streams-constants
Mar 19, 2019
Merged

MINOR: updated deprecated streams constants#191
mjsax merged 2 commits into
apache:asf-sitefrom
londoncalling:Kafka-deprecated-streams-constants

Conversation

@londoncalling

@londoncalling londoncalling commented Mar 18, 2019

Copy link
Copy Markdown

Description

Docs update: Streams Developer Guide

  • KEY_SERDE_CLASS_CONFIG and VALUE_KEY_SERDE_CLASS_CONFIG were deprecated in https://kafka.apache.org/11/javadoc/deprecated-list.html and replaced by DEFAULT_KEY_SERDE_CLASS_CONFIG and DEFAULT_VALUE_KEY_SERDE_CLASS_CONFIG

  • Replaced deprecated constants in example code with up-to-date ones in 11 and all subsequent versions

Related

PR on apache/kafka: apache/kafka#6466

cc, please review/merge:

Signed-off-by: Victoria Bialas vicky@confluent.io

Signed-off-by: Victoria Bialas <vicky@confluent.io>

@JimGalasyn JimGalasyn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjsax

mjsax commented Mar 19, 2019

Copy link
Copy Markdown
Member

Thanks for the PR @londoncalling! Both configs are deprecated since 0.11.0.0 release (compare https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68714788) -- can we update 0.11 and 1.0, too in this PR? The mentioned KIP also deprecates timestamp.extractor in favor of default.timestamp.extractor -- would be good to include this in this PR, too.

@londoncalling

londoncalling commented Mar 19, 2019

Copy link
Copy Markdown
Author

@mjsax , on the most recent commit, I replaced TIMESTAMP_EXTRACTOR_CLASS_CONFIG with DEFAULT_TIMESTAMP_EXTRACTOR_CLASS_CONFIG in the code example for defining a custom timestamp extractor in Developer Guide topic on Configuring a Streams Application on these versions:

  • 10/streams/developer-guide/config-streams.html
  • 11/streams/developer-guide/config-streams.html
  • 20/streams/developer-guide/config-streams.html
  • 21/streams/developer-guide/config-streams.html
  • 22/streams/developer-guide/config-streams.html

It looks like it's already covered in the generated Javadoc. Let me know if this fixes it, and feel free to merge if all looks good!

…onfig

Signed-off-by: Victoria Bialas <vicky@confluent.io>
@londoncalling londoncalling changed the title Docs: updated deprecated serdes streams constants MINOR: updated deprecated streams constants Mar 19, 2019
@mjsax
mjsax merged commit 3616b7a into apache:asf-site Mar 19, 2019
@mjsax

mjsax commented Mar 19, 2019

Copy link
Copy Markdown
Member

Thanks a lot for the PR @londoncalling!

@londoncalling
londoncalling deleted the Kafka-deprecated-streams-constants branch April 23, 2019 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants