Skip to content

MINOR: Improve verification in flaky testPartitionReassignmentDuringDeleteTopic #6460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajinisivaram merged 1 commit into from
Mar 18, 2019
Merged

MINOR: Improve verification in flaky testPartitionReassignmentDuringDeleteTopic #6460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,11 @@ class DeleteTopicTest extends ZooKeeperTestHarness {
}, "Partition reassignment shouldn't complete.")
val controllerId = zkClient.getControllerId.getOrElse(fail("Controller doesn't exist"))
val controller = servers.filter(s => s.config.brokerId == controllerId).head
assertFalse("Partition reassignment should fail",
controller.kafkaController.controllerContext.partitionsBeingReassigned.contains(topicPartition))

// partitionsBeingReassigned is updated after re-assignment znode is removed, so wait again
TestUtils.waitUntilTrue(() => {
!controller.kafkaController.controllerContext.partitionsBeingReassigned.contains(topicPartition)
}, "Partition should be removed from partitionsBeingReassigned.")
val assignedReplicas = zkClient.getReplicasForPartition(new TopicPartition(topic, 0))
assertEquals("Partition should not be reassigned to 0, 1, 2", oldAssignedReplicas, assignedReplicas)
follower.startup()
Expand Down