MINOR: Improve verification in flaky testPartitionReassignmentDuringDeleteTopic - #6460
Merged
Merged
Conversation
rajinisivaram
approved these changes
Mar 18, 2019
rajinisivaram
left a comment
rajinisivaram
left a comment
Contributor
There was a problem hiding this comment.
@apovzner Thanks for the PR, LGTM
Contributor
|
Merging to trunk and 2.2 |
rajinisivaram
pushed a commit
that referenced
this pull request
Mar 18, 2019
…eleteTopic (#6460) Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* apache/trunk: MINOR: Improve logging around index files (apache#6385) KAFKA-7858: Automatically generate JoinGroup request/response KAFKA-8121; Shutdown ZK client expiry handler earlier during close (apache#6462) MINOR: Improve verification in flaky testPartitionReassignmentDuringDeleteTopic (apache#6460)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…eleteTopic (apache#6460) Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw one failure in testPartitionReassignmentDuringDeleteTopic unit test couple of months ago. The investigation so far did not find any real failure. However, the test checks whether
controller.kafkaController.controllerContext.partitionsBeingReassignedcontains partition being reassigned after verifying that reassignment znode does not exist anymore (viaReassignPartitionsCommand.checkIfPartitionReassignmentSucceeded).controller.kafkaController.controllerContext.partitionsBeingReassignedis updated after znode is deleted, so there is a very small chance that partitions still exists inpartitionsBeingReassigned. This PR adds a waited check forpartitionsBeingReassigned.Committer Checklist (excluded from commit message)