Skip to content

HOTFIX: check logic of KAFKA-2515 should be on buffer.limit() #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guozhangwang wants to merge 2 commits into from
Closed

HOTFIX: check logic of KAFKA-2515 should be on buffer.limit() #332

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76c4bde
KAFKA-2515.hf
guozhangwang Oct 20, 2015
4578e50
comment minor fix
guozhangwang Oct 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,8 @@ private void handleFetchResponse(ClientResponse resp, FetchRequest request) {
this.subscriptions.fetched(tp, record.offset() + 1);
this.records.add(new PartitionRecords<>(fetchOffset, tp, parsed));
this.sensors.recordsFetchLag.record(partition.highWatermark - record.offset());
} else if (buffer.capacity() >= this.fetchSize) {
// we did not read a single message from a max fetchable buffer
} else if (buffer.limit() > 0) {
// we did not read a single message from an non-empty buffer

@junrao junrao Oct 20, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an non-empty => a non-empty

// because that message's size is larger than fetch size, in this case
// record this exception
this.recordTooLargePartitions.put(tp, fetchOffset);
Expand Down