HOTFIX: check logic of KAFKA-2515 should be on buffer.limit()#332
Closed
guozhangwang wants to merge 2 commits into
Closed
HOTFIX: check logic of KAFKA-2515 should be on buffer.limit()#332guozhangwang wants to merge 2 commits into
guozhangwang wants to merge 2 commits into
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
an non-empty => a non-empty
Contributor
|
Thanks for the patch. Just a minor comment. Otherwise, LGTM. |
Contributor
|
Agreed, LGTM and validated that this was (at least one case...) causing the system tests to fail. |
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
May 16, 2022
LI_DESCRIPTION = Linkedin internal system blocks jar import on dependencies that declares a dependency transitively. For example, with a dependency chain ``` A > B > C ``` when C is found vulnerable, both A & B will be blocked, which is normal. However, if A pins a fixed C' and the dependency becomes ``` A > B > C > C' // Which should resolve to A, B, C' ``` A is still blocked even if the whole dependency resolution does not include vulnerable C, because the system still blocks B, and it thinks "A is not usable without B", thus rejecting importing A. In order to get over this, we have to down pin B to a lib that already exists internally (in this specific use case, all non-`databind` `jackson` dependencies) while maintaining the directly vulnerable library C (in this case, `jackson-databind`) pinned to a fixed, non-vulnerable version. TICKET = CVE-2020-36518, KAFKA-13775 EXIT_CRITERIA = "When upstream bumps all `jackson` series to >= `2.13.3`"
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
LI_DESCRIPTION = Linkedin internal system blocks jar import on dependencies that declares a dependency transitively. For example, with a dependency chain ``` A > B > C ``` when C is found vulnerable, both A & B will be blocked, which is normal. However, if A pins a fixed C' and the dependency becomes ``` A > B > C > C' // Which should resolve to A, B, C' ``` A is still blocked even if the whole dependency resolution does not include vulnerable C, because the system still blocks B, and it thinks "A is not usable without B", thus rejecting importing A. In order to get over this, we have to down pin B to a lib that already exists internally (in this specific use case, all non-`databind` `jackson` dependencies) while maintaining the directly vulnerable library C (in this case, `jackson-databind`) pinned to a fixed, non-vulnerable version. TICKET = CVE-2020-36518, KAFKA-13775 EXIT_CRITERIA = "When upstream bumps all `jackson` series to >= `2.13.3`"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.