-
Notifications
You must be signed in to change notification settings - Fork 15.4k
MINOR Add status check for gradle scan #17140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
8ae831d
Capture URL
mumrah b4c5a45
shorten the CI
mumrah 9f3c9c6
only run for PRs
mumrah 0ae0550
Fix env
mumrah e149058
fix whitespace
mumrah fd4349d
add a comment
mumrah 93fa110
fix comment
mumrah aa28cc5
one comment for both scans
mumrah f7b24f0
fix quote
mumrah 0346b06
use status check
mumrah 01a739e
empty
mumrah 31ec37b
fix outputs
mumrah 0341fdd
update workflow
mumrah beeb8e1
try composite action
mumrah 5cee8ff
Merge branch 'mumrah-trunk' into gh-test-build-scan-comment
mumrah 6ca348c
fix workflow
mumrah aacd31b
pass token
mumrah c72d7da
fix state
mumrah 363a96e
fix state value
mumrah 0a34da8
clear check before run
mumrah f8ca2a0
Merge branch 'mumrah-trunk' into gh-test-build-scan-comment
mumrah d6e72df
only clear the check in test job
mumrah 8a864a2
Merge branch 'mumrah-trunk' into gh-test-build-scan-comment
mumrah ca8ffb4
add failure check
mumrah ee781a4
fix syntax
mumrah e2bb9f5
add url for failure
mumrah a8e211e
remove failure
mumrah 654acaf
empty
mumrah f3fa9c4
Merge branch 'mumrah-trunk' into gh-test-build-scan-comment
mumrah 6cfcdcb
run full tests
mumrah de87548
add step conditions
mumrah 8c0ca40
simulate failure
mumrah eb3a652
add conditions to steps
mumrah 6f1bfad
add summary
mumrah 812c731
Merge branch 'mumrah-trunk' into gh-test-build-scan-comment
mumrah 89396ae
remove failure
mumrah e18df31
simulate failure
mumrah 27ad4d9
remove failure
mumrah fcbe54f
Merge branch 'mumrah-trunk' into gh-test-build-scan-comment
mumrah 748909a
run all tests
mumrah 0a1423e
cat the gradle stdout
mumrah c745f11
PR feedback
mumrah 3896ab0
Merge remote-tracking branch 'origin/trunk' into gh-test-build-scan-c…
mumrah f17700e
more PR feedback
mumrah 93a9216
missed slash
mumrah a7e801f
document no-scan
mumrah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
| --- | ||
| name: "Update Commit Status Check" | ||
| description: "Update the status of a commit check using the GH CLI" | ||
| inputs: | ||
| gh-token: | ||
| description: "The GitHub token for use with the CLI" | ||
| required: true | ||
| repository: | ||
| description: "The repository where the commit is located" | ||
| default: "apache/kafka" | ||
| commit_sha: | ||
| description: "The SHA of the commit we are updating" | ||
| required: true | ||
| url: | ||
| description: "The URL of the status check" | ||
| required: false | ||
| default: "" | ||
| description: | ||
| description: "The text to display next to the check" | ||
| default: "" | ||
| required: false | ||
| context: | ||
| description: "The name of the status check" | ||
| required: true | ||
| state: | ||
| description: "The state of the check. Can be one of: error, failure, pending, success" | ||
| required: true | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Update Check | ||
| shell: bash | ||
| env: | ||
| GH_TOKEN: ${{ inputs.gh-token }} | ||
| run: | | ||
| gh api --method POST -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" \ | ||
| /repos/${{ inputs.repository }}/statuses/${{ inputs.commit_sha }} \ | ||
| -f "state=${{ inputs.state }}" -f "target_url=${{ inputs.url }}" \ | ||
| -f "description=${{ inputs.description }}" \ | ||
| -f "context=${{ inputs.context }}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please comment to https://github.com/apache/kafka/blob/trunk/.github/workflows/build.yml#L88 to remind that we need to keep the JDK consistency.