Skip to content

MINOR Add status check for gradle scan#17140

Merged
mumrah merged 46 commits into
apache:trunkfrom
mumrah:gh-test-build-scan-comment
Sep 9, 2024
Merged

MINOR Add status check for gradle scan#17140
mumrah merged 46 commits into
apache:trunkfrom
mumrah:gh-test-build-scan-comment

Conversation

@mumrah

@mumrah mumrah commented Sep 9, 2024

Copy link
Copy Markdown
Member

Add a commit status check so PRs can easily access the build scan.

@mumrah
mumrah marked this pull request as draft September 9, 2024 16:48
@mumrah

mumrah commented Sep 9, 2024

Copy link
Copy Markdown
Member Author

Example of when the CI workflow does not produce any build scan artifacts:
https://github.com/mumrah/kafka/actions/runs/10777726936

Example of when it does produce artifacts, and publishes:
https://github.com/mumrah/kafka/actions/runs/10777816130

PR
image

Example of when it does produce artifacts, but fails to publish:
Job: https://github.com/mumrah/kafka/actions/runs/10777898146 (in a real failure, there would be no build scan links here)

PR
image

@mumrah
mumrah marked this pull request as ready for review September 9, 2024 17:11
@mumrah
mumrah requested a review from chia7712 September 9, 2024 17:12
@mumrah

mumrah commented Sep 9, 2024

Copy link
Copy Markdown
Member Author

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mumrah thanks for this interesting idea. It’s cool!

Comment thread .github/workflows/ci-complete.yml Outdated
./gradlew --info buildScanPublishPrevious > gradle.out
SCAN_URL=$(grep '^https://.*$' gradle.out)
cat gradle.out
echo "Published build scan to $SCAN_URL"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add it to GITHUB_STEP_SUMMARY?

Comment thread .github/workflows/ci-complete.yml
Comment thread .github/workflows/ci-complete.yml
@mumrah
mumrah requested a review from chia7712 September 9, 2024 18:09
@chia7712

chia7712 commented Sep 9, 2024

Copy link
Copy Markdown
Member

@mumrah just a discussion: Have you evaluated the runner quota? the GitHub Actions Policy says:

The average number of minutes a project uses per calendar week MUST NOT exceed the equivalent of 25 full-time runners (250,000 minutes, or 4,200 hours).

If 1 commit needs 4 hours (4 checks + 2 test suits), we can run 1050 commits one week. The Pulse says there are 54 merges/commits one week, so we have about 1000 remaining quota can be used by PRs. Hence, it seems kafka community will NOT burn out GitHub runner. WDYT?

@mumrah

mumrah commented Sep 9, 2024

Copy link
Copy Markdown
Member Author

@chia7712

Have you evaluated the runner quota

I've been watching the Infra report here https://infra-reports.apache.org/#ghactions (requires committer sign-in). Right now, the "CI" workflow (both trunk and PRs) has averaged 3 full-time runners over the last week.

Hence, it seems kafka community will NOT burn out GitHub runner. WDYT?

I think this is correct. Even with the addition of all PRs running the full test suite, I think we'll be well under this limit. Part of the reason I wanted to get caching working before turning it on for all PRs was to avoid increasing our usage too much.

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mumrah overall +1 except for some minor comments.

fail-fast: false
matrix:
java: [ 21, 17, 11, 8 ]
java: [ 17, 11 ]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please comment to https://github.com/apache/kafka/blob/trunk/.github/workflows/build.yml#L88 to remind that we need to keep the JDK consistency.

Comment thread .github/workflows/ci-complete.yml
@mumrah
mumrah merged commit 4d182d1 into apache:trunk Sep 9, 2024
mingyen066 pushed a commit to mingyen066/kafka that referenced this pull request Sep 10, 2024
Add a commit status check so PRs can easily access the build scan.

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Add a commit status check so PRs can easily access the build scan.

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Gradle build or GitHub Actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants