MINOR Add status check for gradle scan#17140
Conversation
|
Example of when the CI workflow does not produce any build scan artifacts: Example of when it does produce artifacts, and publishes: Example of when it does produce artifacts, but fails to publish: |
|
@chia7712 I have added an explanation of how this workflow works with the CI here https://github.com/apache/kafka/pull/17140/files#diff-03dbd91a7c60e880a3123759ea4ab422044357e5d1d75450d63bbcbd064cd0d9R26-R36 |
| ./gradlew --info buildScanPublishPrevious > gradle.out | ||
| SCAN_URL=$(grep '^https://.*$' gradle.out) | ||
| cat gradle.out | ||
| echo "Published build scan to $SCAN_URL" |
There was a problem hiding this comment.
Maybe we can add it to GITHUB_STEP_SUMMARY?
|
@mumrah just a discussion: Have you evaluated the runner quota? the GitHub Actions Policy says: If 1 commit needs 4 hours (4 checks + 2 test suits), we can run 1050 commits one week. The Pulse says there are 54 merges/commits one week, so we have about 1000 remaining quota can be used by PRs. Hence, it seems kafka community will NOT burn out GitHub runner. WDYT? |
I've been watching the Infra report here https://infra-reports.apache.org/#ghactions (requires committer sign-in). Right now, the "CI" workflow (both trunk and PRs) has averaged 3 full-time runners over the last week.
I think this is correct. Even with the addition of all PRs running the full test suite, I think we'll be well under this limit. Part of the reason I wanted to get caching working before turning it on for all PRs was to avoid increasing our usage too much. |
| fail-fast: false | ||
| matrix: | ||
| java: [ 21, 17, 11, 8 ] | ||
| java: [ 17, 11 ] |
There was a problem hiding this comment.
Could you please comment to https://github.com/apache/kafka/blob/trunk/.github/workflows/build.yml#L88 to remind that we need to keep the JDK consistency.
Add a commit status check so PRs can easily access the build scan. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Add a commit status check so PRs can easily access the build scan. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>


Add a commit status check so PRs can easily access the build scan.