Skip to content

MINOR: Add integration test for plugin aliases #16621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
C0urante merged 3 commits into from
Jul 19, 2024
Merged

MINOR: Add integration test for plugin aliases #16621

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
026474d
Add integration test for plugin aliases
C0urante Jul 17, 2024
b42f8a2
Fix sink connector name, delete connectors after they're used
C0urante Jul 18, 2024
9747c21
Use correct Jira ticket number in topic name
C0urante Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions ...time/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
import org.apache.kafka.connect.sink.SinkTask;
import org.apache.kafka.connect.storage.KafkaConfigBackingStore;
import org.apache.kafka.connect.storage.StringConverter;
import org.apache.kafka.connect.transforms.Filter;
import org.apache.kafka.connect.transforms.predicates.RecordIsTombstone;
import org.apache.kafka.connect.util.ConnectorTaskId;
import org.apache.kafka.connect.util.SinkUtils;
import org.apache.kafka.connect.util.clusters.EmbeddedConnectCluster;
Expand Down Expand Up @@ -80,9 +82,12 @@
import static org.apache.kafka.connect.integration.MonitorableSourceConnector.TOPIC_CONFIG;
import static org.apache.kafka.connect.runtime.ConnectorConfig.CONNECTOR_CLASS_CONFIG;
import static org.apache.kafka.connect.runtime.ConnectorConfig.CONNECTOR_CLIENT_PRODUCER_OVERRIDES_PREFIX;
import static org.apache.kafka.connect.runtime.ConnectorConfig.HEADER_CONVERTER_CLASS_CONFIG;
import static org.apache.kafka.connect.runtime.ConnectorConfig.KEY_CONVERTER_CLASS_CONFIG;
import static org.apache.kafka.connect.runtime.ConnectorConfig.PREDICATES_CONFIG;
import static org.apache.kafka.connect.runtime.ConnectorConfig.TASKS_MAX_CONFIG;
import static org.apache.kafka.connect.runtime.ConnectorConfig.TASKS_MAX_ENFORCE_CONFIG;
import static org.apache.kafka.connect.runtime.ConnectorConfig.TRANSFORMS_CONFIG;
import static org.apache.kafka.connect.runtime.ConnectorConfig.VALUE_CONVERTER_CLASS_CONFIG;
import static org.apache.kafka.connect.runtime.SinkConnectorConfig.TOPICS_CONFIG;
import static org.apache.kafka.connect.runtime.TopicCreationConfig.DEFAULT_TOPIC_CREATION_PREFIX;
Expand Down Expand Up @@ -1375,6 +1380,57 @@ public void testRuntimePropertyReconfiguration() throws Exception {
);
}

@Test
public void testPluginAliases() throws Exception {
connect = connectBuilder.build();
// start the clusters
connect.start();

// Create a topic; not strictly necessary but prevents log spam when we start a source connector later
final String topic = "kafka17510";

@chia7712 chia7712 Jul 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the correct jira number is "17150"

@C0urante C0urante Jul 19, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your eye for detail never ceases to impress me 😄
Fixed in the latest commit.

connect.kafka().createTopic(topic, 1);

Map<String, String> baseConnectorConfig = new HashMap<>();
// General connector properties
baseConnectorConfig.put(TASKS_MAX_CONFIG, Integer.toString(NUM_TASKS));
// Aliased converter classes
baseConnectorConfig.put(KEY_CONVERTER_CLASS_CONFIG, StringConverter.class.getSimpleName());
baseConnectorConfig.put(VALUE_CONVERTER_CLASS_CONFIG, StringConverter.class.getSimpleName());
baseConnectorConfig.put(HEADER_CONVERTER_CLASS_CONFIG, StringConverter.class.getSimpleName());
// Aliased SMT and predicate classes
baseConnectorConfig.put(TRANSFORMS_CONFIG, "filter");
baseConnectorConfig.put(TRANSFORMS_CONFIG + ".filter.type", Filter.class.getSimpleName());
baseConnectorConfig.put(TRANSFORMS_CONFIG + ".filter.predicate", "tombstone");
baseConnectorConfig.put(PREDICATES_CONFIG, "tombstone");
baseConnectorConfig.put(PREDICATES_CONFIG + ".tombstone.type", RecordIsTombstone.class.getSimpleName());

// Test a source connector
final String sourceConnectorName = "plugins-alias-test-source";
Map<String, String> sourceConnectorConfig = new HashMap<>(baseConnectorConfig);
// Aliased source connector class
sourceConnectorConfig.put(CONNECTOR_CLASS_CONFIG, MonitorableSourceConnector.class.getSimpleName());
// Connector-specific properties
sourceConnectorConfig.put(TOPIC_CONFIG, topic);
sourceConnectorConfig.put("throughput", "10");
sourceConnectorConfig.put("messages.per.poll", String.valueOf(MESSAGES_PER_POLL));
// Create the connector and ensure it and its tasks can start
connect.configureConnector(sourceConnectorName, sourceConnectorConfig);
connect.assertions().assertConnectorAndExactlyNumTasksAreRunning(sourceConnectorName, NUM_TASKS, "Connector and tasks did not start in time");
connect.deleteConnector(sourceConnectorName);

// Test a sink connector
final String sinkConnectorName = "plugins-alias-test-sink";
Map<String, String> sinkConnectorConfig = new HashMap<>(baseConnectorConfig);
// Aliased sink connector class
sinkConnectorConfig.put(CONNECTOR_CLASS_CONFIG, MonitorableSinkConnector.class.getSimpleName());
// Connector-specific properties
sinkConnectorConfig.put(TOPICS_CONFIG, topic);
// Create the connector and ensure it and its tasks can start
connect.configureConnector(sinkConnectorName, sinkConnectorConfig);
connect.assertions().assertConnectorAndExactlyNumTasksAreRunning(sinkConnectorName, NUM_TASKS, "Connector and tasks did not start in time");
connect.deleteConnector(sinkConnectorName);
}

private Map<String, String> defaultSourceConnectorProps(String topic) {
// setup props for the source connector
Map<String, String> props = new HashMap<>();
Expand Down