MINOR: Add integration test for plugin aliases - #16621
Merged
C0urante merged 3 commits intoJul 19, 2024
Merged
Conversation
chia7712
reviewed
Jul 18, 2024
| sinkConnectorConfig.put(TOPICS_CONFIG, topic); | ||
| // Create the connector and ensure it and its tasks can start | ||
| connect.configureConnector(sinkConnectorName, sinkConnectorConfig); | ||
| connect.assertions().assertConnectorAndExactlyNumTasksAreRunning(sourceConnectorName, NUM_TASKS, "Connector and tasks did not start in time"); |
Member
There was a problem hiding this comment.
It should be sinkConnectorName, right?
Contributor
Author
There was a problem hiding this comment.
🤦 Thanks for the catch! Fixed in the latest commit. I also deleted each connector after they were no longer necessary, just to prevent typos like this from slipping in in the future.
chia7712
approved these changes
Jul 18, 2024
chia7712
left a comment
chia7712
left a comment
Member
There was a problem hiding this comment.
LGTM. one tiny comment is left but it is too tiny to block this PR
| connect.start(); | ||
|
|
||
| // Create a topic; not strictly necessary but prevents log spam when we start a source connector later | ||
| final String topic = "kafka17510"; |
Member
There was a problem hiding this comment.
I guess the correct jira number is "17150"
Contributor
Author
There was a problem hiding this comment.
Your eye for detail never ceases to impress me 😄
Fixed in the latest commit.
Contributor
Author
|
The changes in the latest commit are trivial, the build passes locally, and CI indicates that the prior commit is healthy. Merging... |
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16608, discussed here and here.
Committer Checklist (excluded from commit message)