Skip to content

MINOR: Remove reference to 'offset backing store' from exception message in KafkaBasedLog - #13810

Merged
C0urante merged 1 commit into
apache:trunkfrom
yashmayya:fix-exception-message-kafka-based-log
Jun 5, 2023
Merged

MINOR: Remove reference to 'offset backing store' from exception message in KafkaBasedLog#13810
C0urante merged 1 commit into
apache:trunkfrom
yashmayya:fix-exception-message-kafka-based-log

Conversation

@yashmayya

Copy link
Copy Markdown
Contributor
  • The KafkaBasedLog abstraction is used by Kafka Connect's three metadata topics - offsets, configs, and statuses.
  • This generic KafkaBasedLog was split off from the KafkaOffsetBackingStore here when adding support for the distributed mode in Kafka Connect (specifically for supporting the Kafka topic based config backing store)
  • The exception message in question here wasn't refactored to account for the KafkaBasedLog's generic functionality (versus the offsets topic specific logic in the KafkaOffsetBackingStore)

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@yashmayya
yashmayya requested a review from C0urante June 5, 2023 12:21

@C0urante C0urante left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Yash!

@C0urante

C0urante commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Similar to #13808 (comment), I've verified locally that this builds correctly and, given the extremely limited scope of the change, feel comfortable merging without waiting for CI first.

@C0urante
C0urante merged commit fca7ee7 into apache:trunk Jun 5, 2023
arianizadi pushed a commit to GonzalooDelgado/kafka that referenced this pull request Nov 3, 2025
…age in KafkaBasedLog (apache#13810)

Reviewers: Chris Egerton <chrise@aiven.io>
(cherry picked from commit fca7ee7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants