Skip to content

MINOR: Handle the config topic read timeout edge case in DistributedHerder's stopConnector method#13750

Merged
C0urante merged 2 commits into
apache:trunkfrom
yashmayya:stop-connector-config-topic-read-timeout
Jun 5, 2023
Merged

MINOR: Handle the config topic read timeout edge case in DistributedHerder's stopConnector method#13750
C0urante merged 2 commits into
apache:trunkfrom
yashmayya:stop-connector-config-topic-read-timeout

Conversation

@yashmayya

Copy link
Copy Markdown
Contributor

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@yashmayya
yashmayya requested a review from C0urante May 23, 2023 16:36
…t on the config topic read after writing a stopped target state

@C0urante C0urante left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yash! LGTM

@C0urante

C0urante commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Similar to #13808 (comment) and #13810 (comment), I've verified locally that this builds correctly and, given the extremely limited scope of the change, feel comfortable merging without waiting for CI first.

@C0urante
C0urante merged commit 383a8d6 into apache:trunk Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants