KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest#13549
Closed
gharris1727 wants to merge 1 commit into
Closed
KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest#13549gharris1727 wants to merge 1 commit into
gharris1727 wants to merge 1 commit into
Conversation
…zerTest Signed-off-by: Greg Harris <greg.harris@aiven.io>
Contributor
Author
|
@cmccabe Could you review this fix? |
Contributor
Author
|
This duplicates #13543 so I'll close this in favor of that more comprehensive change. |
Contributor
|
Thanks @gharris1727 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that raftManager can become null via ControllerServer.shutdown() -> ensureNotRaftLeader() and various call sites of stop(). Rather than emit an NPE, evaluate raftManager.client while it is known to be non-null, and pass the evaluated client into the setHighWaterMarkAccessor.
I unfortunately don't have much context here, and I'm not sure if once raftManager becomes null, if it is still reasonable to evaluate highWatermark(), or whether the HighWaterMarkAccessor should return empty.
Committer Checklist (excluded from commit message)