MINOR: fix flaky KRaft-related tests#13543
Merged
Merged
Conversation
cmccabe
changed the title
cmccabe
added a commit
to cmccabe/kafka
that referenced
this pull request
Apr 12, 2023
In SharedServer, fix some cases where a volatile variable could change to null while we were using it, during shutdown. This is mainly a junit test issue, although it could also cause ugly error messages during shutdown when running the server in a production context. Fix a race in KafkaEventQueueTest.testSize.
cmccabe
force-pushed
the
cmccabe_2023-04-11_fix_test_issues
branch
from
April 12, 2023 19:12
7cdb5a3 to
aa77656
Compare
3 tasks
mumrah
approved these changes
Apr 13, 2023
In SharedServer, fix some cases where a volatile variable could change to null while we were using it, during shutdown. This is mainly a junit test issue, although it could also cause ugly error messages during shutdown when running the server in a production context. Fix a race in KafkaEventQueueTest.testSize.
cmccabe
force-pushed
the
cmccabe_2023-04-11_fix_test_issues
branch
from
April 14, 2023 17:09
aa77656 to
9a53315
Compare
Member
|
Cherry-picking this to 3.5. |
ijuma
pushed a commit
that referenced
this pull request
Apr 15, 2023
In SharedServer, fix some cases where a volatile variable could change to null while we were using it, during shutdown. This is mainly a junit test issue, although it could also cause ugly error messages during shutdown when running the server in a production context. Fix a race in KafkaEventQueueTest.testSize. Reviewers: David Arthur <mumrah@gmail.com>
showuon
pushed a commit
that referenced
this pull request
May 15, 2023
In SharedServer, fix some cases where a volatile variable could change to null while we were using it, during shutdown. This is mainly a junit test issue, although it could also cause ugly error messages during shutdown when running the server in a production context. Fix a race in KafkaEventQueueTest.testSize. Reviewers: David Arthur <mumrah@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SharedServer, fix some cases where a volatile variable could change to null while we were using
it, during shutdown. This is mainly a junit test issue, although it could also cause ugly error
messages during shutdown when running the server in a production context.
Fix a race in KafkaEventQueueTest.testSize.