Skip to content

KAFKA-13971:Atomicity violations caused by improper usage of ConcurrentHashMap #12277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
C0urante merged 3 commits into from
Aug 17, 2022
Merged

KAFKA-13971:Atomicity violations caused by improper usage of ConcurrentHashMap #12277

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ed0693
be thread safe
Kvicii Jun 9, 2022
0742d4f
revert
Kvicii Jun 9, 2022
b09132e
replace
Kvicii Jun 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfigTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,25 +78,20 @@ private void scheduleReload(String connectorName, Map<String, Long> ttls) {
}

private void scheduleReload(String connectorName, String path, long ttl) {
Map<String, HerderRequest> connectorRequests = requests.get(connectorName);
if (connectorRequests == null) {
connectorRequests = new ConcurrentHashMap<>();
requests.put(connectorName, connectorRequests);
} else {
HerderRequest previousRequest = connectorRequests.get(path);
Map<String, HerderRequest> connectorRequests = requests.computeIfAbsent(connectorName, s -> new ConcurrentHashMap<>());
connectorRequests.compute(path, (s, previousRequest) -> {
if (previousRequest != null) {
// Delete previous request for ttl which is now stale
previousRequest.cancel();
}
}
log.info("Scheduling a restart of connector {} in {} ms", connectorName, ttl);
Callback<Void> cb = (error, result) -> {
if (error != null) {
log.error("Unexpected error during connector restart: ", error);
}
};
HerderRequest request = worker.herder().restartConnector(ttl, connectorName, cb);
connectorRequests.put(path, request);
log.info("Scheduling a restart of connector {} in {} ms", connectorName, ttl);
Callback<Void> cb = (error, result) -> {
if (error != null) {
log.error("Unexpected error during connector restart: ", error);
}
};
return worker.herder().restartConnector(ttl, connectorName, cb);
});
}

@Override
Expand Down