KAFKA-13971:Atomicity violations caused by improper usage of ConcurrentHashMap#12277
Merged
Conversation
Kvicii
changed the title
divijvaidya
reviewed
Jun 10, 2022
divijvaidya
approved these changes
Jun 11, 2022
divijvaidya
left a comment
divijvaidya
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing the code as per the suggestion. LGTM!
Contributor
Author
|
@hachikuji can you help me review this PR? |
Member
|
We should check if this code is used in a concurrent context. Will leave it to @C0urante. |
C0urante
approved these changes
Aug 17, 2022
C0urante
left a comment
C0urante
left a comment
Contributor
There was a problem hiding this comment.
It's unlikely but definitely possible for scheduleReload to be invoked concurrently, since tasks are allowed to access their own configs through their SourceTaskContext/SinkTaskContext.
I wish we could have a test for this but considering how tricky it is to reliably reproduce race conditions and how simple the changes are, I'm comfortable making an exception and merging this change without a unit test.
LGTM, thanks @Kvicii!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensure thread safe
Committer Checklist (excluded from commit message)