Skip to content

KAFKA-13457: SocketChannel in Acceptor#accept is not closed upon IOException #11504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dajac merged 6 commits into from
Nov 24, 2021
Merged

KAFKA-13457: SocketChannel in Acceptor#accept is not closed upon IOException #11504

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd7f0b5
KAFKA-13457: socketChannel in Acceptor#accept is not closed upon IOEx…
functioner Nov 16, 2021
0cd1827
update exception handling
functioner Nov 16, 2021
f5adb06
add test
functioner Nov 20, 2021
309e143
Merge branch 'trunk' of https://github.com/apache/kafka into KAFKA-13457
functioner Nov 22, 2021
6f07bfe
update log and test
functioner Nov 22, 2021
c196e3b
update test
functioner Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/scala/kafka/network/SocketServer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,10 @@ private[kafka] class Acceptor(val endPoint: EndPoint,
val endThrottleTimeMs = e.startThrottleTimeMs + e.throttleTimeMs
throttledSockets += DelayedCloseSocket(socketChannel, endThrottleTimeMs)
None
case e: IOException =>
info(s"Encounter IOException", e)
closeSocket(socketChannel)
None
}
}

Expand Down