KAFKA-13457: SocketChannel in Acceptor#accept is not closed upon IOException

[functioner]

A patch for KAFKA-13457

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[showuon]

@functioner , thanks for finding this issue and fixing it. LGTM! Left a minor comment. Thanks.

[dajac]

@functioner Thanks for the patch.

It seems that the fix does not fully match the description in the JIRA. In the JIRA, you wrote the following: However, line 717 or the socketChannel operations within the try block may potentially throw an IOException as well, which is not handled.. And you refers to this line:

val socketChannel = serverSocketChannel.accept()     // line 717

The try/catch block where the IOException has been added does not wrap that line so it does not catch it. I suppose that the description of the JIRA is incorrect in this case because we can't close the socketChannel if we don't have it.

However, it seems to be that such issue could be caused by socketChannel.configureBlocking(false) which could also thrown an IOException. Am I getting this right?

Do you think that we could add a unit test for this bug?

[functioner]

Are there any other issues or concern with the current patch and test? If any, I will resolve ASAP. Will this PR be merged soon by any chance?

[dajac]

@functioner It seems that the code does not compile. I seems to be due to 30a9085 which added an parameter to the Acceptor's constructor. Could you rebase or merge trunk into your branch?

[dajac]

Thanks for the update. Left a few comments.

[dajac]

LGTM, thanks for the patch.

[functioner]

Thanks everybody here for the suggestions and merging the patch!