Skip to content

KAFKA-12790: Remove SslTransportLayerTest.testUnsupportedTlsVersion #10922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ijuma merged 3 commits into from
Jun 27, 2021
Merged

KAFKA-12790: Remove SslTransportLayerTest.testUnsupportedTlsVersion #10922

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34bc133
KAFKA-12790: Fix SslTransportLayerTest.testUnsupportedTlsVersion with…
ijuma Jun 23, 2021
b8cf066
Fix NPE in finally block
rajinisivaram Jun 23, 2021
03fba29
Delete test
ijuma Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
*/
package org.apache.kafka.common.network;

import java.security.Security;
import org.apache.kafka.common.KafkaException;
import org.apache.kafka.common.config.SslConfigs;
import org.apache.kafka.common.config.internals.BrokerSecurityConfigs;
Expand All @@ -36,8 +37,6 @@
import org.apache.kafka.test.TestSslUtils;
import org.apache.kafka.test.TestUtils;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.condition.DisabledOnJre;
import org.junit.jupiter.api.condition.JRE;
import org.junit.jupiter.api.extension.ExtensionContext;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
Expand Down Expand Up @@ -632,15 +631,23 @@ private void checkAuthenticationFailed(Args args, String node, String tlsVersion
*/
@ParameterizedTest
@ArgumentsSource(SslTransportLayerArgumentsProvider.class)
@DisabledOnJre(JRE.JAVA_16)
public void testUnsupportedTlsVersion(Args args) throws Exception {
server = createEchoServer(args, SecurityProtocol.SSL);
// Capture the current value so that we can restore at the end of the test
String disabledAlgorithms = System.getProperty("jdk.tls.disabledAlgorithms");
// TLS 1.0 and 1.1 have been disabled in recent versions of Java 8/11 and all versions
// of 16, temporarily allow it so that we can test we send the expected error.
Security.setProperty("jdk.tls.disabledAlgorithms", "");
try {
server = createEchoServer(args, SecurityProtocol.SSL);

checkAuthenticationFailed(args, "0", "TLSv1.1");
server.verifyAuthenticationMetrics(0, 1);
checkAuthenticationFailed(args, "0", "TLSv1.1");
server.verifyAuthenticationMetrics(0, 1);

checkAuthenticationFailed(args, "0", "TLSv1");
server.verifyAuthenticationMetrics(0, 2);
checkAuthenticationFailed(args, "0", "TLSv1");
server.verifyAuthenticationMetrics(0, 2);
} finally {
Security.setProperty("jdk.tls.disabledAlgorithms", disabledAlgorithms);
}
}

/**
Expand Down