KAFKA-12790: Remove SslTransportLayerTest.testUnsupportedTlsVersion#10922
Merged
ijuma merged 3 commits intoJun 27, 2021
Conversation
… recent JDKs Support for TLS 1.0 and 1.1 was disabled in recent versions of Java 8/11 and all versions of 16. Re-enable it in this test so that we can verify the server behavior when it establishes connections with such TLS versions.
rajinisivaram
approved these changes
Jun 23, 2021
rajinisivaram
left a comment
rajinisivaram
left a comment
Contributor
There was a problem hiding this comment.
@ijuma Thanks for the PR, LGTM
showuon
approved these changes
Jun 24, 2021
showuon
left a comment
showuon
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for fixing the failed tests!
rajinisivaram
approved these changes
Jun 25, 2021
rajinisivaram
left a comment
rajinisivaram
left a comment
Contributor
There was a problem hiding this comment.
@ijuma Thanks for the update LGTM
ijuma
changed the title
ijuma
changed the title
ijuma
added a commit
that referenced
this pull request
Jun 27, 2021
…10922) Support for TLS 1.0/1.1 was disabled in recent versions of Java 8/11 and all versions of 16 causing this test to fail. It is possible to make it work by updating the relevant security property, but it has to be done before the affected classes are loaded and it can not be disabled after that. Given the low value of the test, we remove it. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Luke Chen <showuon@gmail.com>
ijuma
added a commit
that referenced
this pull request
Jun 28, 2021
…10922) Support for TLS 1.0/1.1 was disabled in recent versions of Java 8/11 and all versions of 16 causing this test to fail. It is possible to make it work by updating the relevant security property, but it has to be done before the affected classes are loaded and it can not be disabled after that. Given the low value of the test, we remove it. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Luke Chen <showuon@gmail.com>
ijuma
added a commit
that referenced
this pull request
Jun 28, 2021
…10922) Support for TLS 1.0/1.1 was disabled in recent versions of Java 8/11 and all versions of 16 causing this test to fail. It is possible to make it work by updating the relevant security property, but it has to be done before the affected classes are loaded and it can not be disabled after that. Given the low value of the test, we remove it. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Luke Chen <showuon@gmail.com>
ijuma
added a commit
that referenced
this pull request
Jun 28, 2021
…10922) Support for TLS 1.0/1.1 was disabled in recent versions of Java 8/11 and all versions of 16 causing this test to fail. It is possible to make it work by updating the relevant security property, but it has to be done before the affected classes are loaded and it can not be disabled after that. Given the low value of the test, we remove it. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Luke Chen <showuon@gmail.com>
ijuma
added a commit
that referenced
this pull request
Jun 28, 2021
…10922) Support for TLS 1.0/1.1 was disabled in recent versions of Java 8/11 and all versions of 16 causing this test to fail. It is possible to make it work by updating the relevant security property, but it has to be done before the affected classes are loaded and it can not be disabled after that. Given the low value of the test, we remove it. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Luke Chen <showuon@gmail.com>
Member
Author
|
Cherry-picked to all the branches that have a Jenkins job active. |
3 tasks
ijuma
added a commit
that referenced
this pull request
Jul 20, 2021
…11092) The latest JDKs no longer support TLS 1.0/1.1 causing the test to fail. We have already fixed this in trunk and 3.0, so this is for 2.8 and older branches. The relevant trunk commit is 530224e. We had another test with the same issue and it was fixed for all branches via #10922. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
ijuma
added a commit
that referenced
this pull request
Jul 20, 2021
…11092) The latest JDKs no longer support TLS 1.0/1.1 causing the test to fail. We have already fixed this in trunk and 3.0, so this is for 2.8 and older branches. The relevant trunk commit is 530224e. We had another test with the same issue and it was fixed for all branches via #10922. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
ijuma
added a commit
that referenced
this pull request
Jul 20, 2021
…11092) The latest JDKs no longer support TLS 1.0/1.1 causing the test to fail. We have already fixed this in trunk and 3.0, so this is for 2.8 and older branches. The relevant trunk commit is 530224e. We had another test with the same issue and it was fixed for all branches via #10922. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
ijuma
added a commit
that referenced
this pull request
Jul 20, 2021
…11092) The latest JDKs no longer support TLS 1.0/1.1 causing the test to fail. We have already fixed this in trunk and 3.0, so this is for 2.8 and older branches. The relevant trunk commit is 530224e. We had another test with the same issue and it was fixed for all branches via #10922. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
…pache#10922) Support for TLS 1.0/1.1 was disabled in recent versions of Java 8/11 and all versions of 16 causing this test to fail. It is possible to make it work by updating the relevant security property, but it has to be done before the affected classes are loaded and it can not be disabled after that. Given the low value of the test, we remove it. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Luke Chen <showuon@gmail.com>
udaynpusa
pushed a commit
to mapr/kafka
that referenced
this pull request
Jan 30, 2024
…pache#11092) The latest JDKs no longer support TLS 1.0/1.1 causing the test to fail. We have already fixed this in trunk and 3.0, so this is for 2.8 and older branches. The relevant trunk commit is 530224e. We had another test with the same issue and it was fixed for all branches via apache#10922. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
udaynpusa
pushed a commit
to mapr/kafka
that referenced
this pull request
Jan 30, 2024
…pache#10922) Support for TLS 1.0/1.1 was disabled in recent versions of Java 8/11 and all versions of 16 causing this test to fail. It is possible to make it work by updating the relevant security property, but it has to be done before the affected classes are loaded and it can not be disabled after that. Given the low value of the test, we remove it. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Luke Chen <showuon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for TLS 1.0/1.1 was disabled in recent versions of Java 8/11
and all versions of 16 causing this test to fail.
It is possible to make it work by updating the relevant security property,
but it has to be done before the affected classes are loaded and it can
not be disabled after that. Given the low value of the test, we remove
it.
Committer Checklist (excluded from commit message)