KAFKA-12338: Remove useless MetadataParser

[dengziming]

More detailed description of your change
MetadataParser is a duplication of MetadataRecordSerde and it's not used in any code, so we can remove it.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
QA

[hachikuji]

@dengziming Thanks for the patch. Looks like the parser has some additional validations which are not present in MetadataRecordSerde. Are any of them worth porting over?

[dengziming]

@hachikuji Thanks for the remindings, I think the validations in read are useful and I copied them to MetadataRecordSerde, but not sure whether the DEFAULT_FRAME_VERSION_SIZE check can be applied to MetadataRecordSerde, because the logic in MetadataParser is size=apiKey+apiVersion+message while in MetadataRecordSerde is size=frameVersion+apiKey+apiVersion+message.

[hachikuji]

It looks like MetadataParseException is already the only thing which can be raised by unsignedIntToShort. Is it necessary to catch it and raise a new instance?

[dengziming]

In fact input.readUnsignedVarint() may throw a IlleagelArgumentException if it fails to read a short, this can be seen in MetadataRecordSerdeTest.testParsingMalformedFrameVersionVarint.

[hachikuji]

Thanks for the updates. Just a few more small comments.

[dengziming]

@hachikuji I update the code according to your suggestions and also make the test more accurate, please take a look again.

[hachikuji]

LGTM. Thanks for the patch!