KAFKA-12338: Consolidate MetadataRecordSerde and MetadataParser serial/deserial code#10159
Closed
dengziming wants to merge 1 commit into
Closed
Conversation
dengziming
force-pushed
the
KAFKA-12338-consolidate-metadata-serde-parser
branch
2 times, most recently
from
February 20, 2021 14:39
2ec9fe2 to
4a31ec0
Compare
Member
Author
|
@cmccabe , Hi, PTAL. |
dengziming
force-pushed
the
KAFKA-12338-consolidate-metadata-serde-parser
branch
from
March 4, 2021 03:23
4a31ec0 to
eeaf54e
Compare
Member
Author
|
Resolved by #10793 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
The logics are duplicated except that
MetadataRecordSerdehas an extraDEFAULT_FRAME_VERSION, if we want to change the serial/deserial format of metadata, we should modify 2 classes, this is unreasonable.Summary of testing strategy (including rationale)
unit test
Committer Checklist (excluded from commit message)