Skip to content

MINOR: StopReplicaResp and StopReplicaReq Test should cover all available version #10068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 3 commits into from
Feb 7, 2021
Merged

MINOR: StopReplicaResp and StopReplicaReq Test should cover all available version #10068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d91a47e
MINOR: StopReplicaResponseTest and StopReplicaRequestTest should cove…
Feb 5, 2021
d728d2c
MINOR: StopReplicaResponseTest and StopReplicaRequestTest should cove…
Feb 5, 2021
012e8ac
Revert "MINOR: StopReplicaResponseTest and StopReplicaRequestTest sho…
Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions clients/src/test/java/org/apache/kafka/common/requests/StopReplicaRequestTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public void testGetErrorResponse() {
}
}

for (short version = STOP_REPLICA.oldestVersion(); version < STOP_REPLICA.latestVersion(); version++) {
for (short version = STOP_REPLICA.oldestVersion(); version <= STOP_REPLICA.latestVersion(); version++) {
StopReplicaRequest.Builder builder = new StopReplicaRequest.Builder(version,
0, 0, 0L, false, topicStates);
StopReplicaRequest request = builder.build();
Expand All @@ -93,7 +93,7 @@ private void testBuilderNormalization(boolean deletePartitions) {
Map<TopicPartition, StopReplicaPartitionState> expectedPartitionStates =
StopReplicaRequestTest.partitionStates(topicStates);

for (short version = STOP_REPLICA.oldestVersion(); version < STOP_REPLICA.latestVersion(); version++) {
for (short version = STOP_REPLICA.oldestVersion(); version <= STOP_REPLICA.latestVersion(); version++) {
StopReplicaRequest request = new StopReplicaRequest.Builder(version, 0, 1, 0,
deletePartitions, topicStates).build(version);
StopReplicaRequestData data = request.data();
Expand Down Expand Up @@ -128,7 +128,7 @@ private void testBuilderNormalization(boolean deletePartitions) {
public void testTopicStatesNormalization() {
List<StopReplicaTopicState> topicStates = topicStates(true);

for (short version = STOP_REPLICA.oldestVersion(); version < STOP_REPLICA.latestVersion(); version++) {
for (short version = STOP_REPLICA.oldestVersion(); version <= STOP_REPLICA.latestVersion(); version++) {
// Create a request for version to get its serialized form
StopReplicaRequest baseRequest = new StopReplicaRequest.Builder(version, 0, 1, 0,
true, topicStates).build(version);
Expand Down Expand Up @@ -163,7 +163,7 @@ public void testTopicStatesNormalization() {
public void testPartitionStatesNormalization() {
List<StopReplicaTopicState> topicStates = topicStates(true);

for (short version = STOP_REPLICA.oldestVersion(); version < STOP_REPLICA.latestVersion(); version++) {
for (short version = STOP_REPLICA.oldestVersion(); version <= STOP_REPLICA.latestVersion(); version++) {
// Create a request for version to get its serialized form
StopReplicaRequest baseRequest = new StopReplicaRequest.Builder(version, 0, 1, 0,
true, topicStates).build(version);
Expand Down
2 changes: 1 addition & 1 deletion clients/src/test/java/org/apache/kafka/common/requests/StopReplicaResponseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public void testErrorCountsFromGetErrorResponse() {
new StopReplicaPartitionState().setPartitionIndex(0),
new StopReplicaPartitionState().setPartitionIndex(1))));

for (short version = STOP_REPLICA.oldestVersion(); version < STOP_REPLICA.latestVersion(); version++) {
for (short version = STOP_REPLICA.oldestVersion(); version <= STOP_REPLICA.latestVersion(); version++) {
StopReplicaRequest request = new StopReplicaRequest.Builder(version,
15, 20, 0, false, topicStates).build(version);
StopReplicaResponse response = request
Expand Down