MINOR: StopReplicaResp and StopReplicaReq Test should cover all available version#10068
Merged
chia7712 merged 3 commits intoFeb 7, 2021
Merged
Conversation
…r all avilaible version
dengziming
changed the title
added 2 commits
February 5, 2021 19:23
…r all avilaible version
…uld cover all avilaible version" This reverts commit d728d2c
Member
|
I've re-triggered Jenkins. I will merge once we have a clean run. |
Member
Author
|
Failures seem unrelated to this pr. |
chia7712
approved these changes
Feb 7, 2021
Member
|
@dengziming Nice patch! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
Accidently found that the test case in
StopReplicaRespTestandStopReplicaReqTestdidn't cover all versions.Summary of testing strategy (including rationale)
QA
Committer Checklist (excluded from commit message)