This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-1330] Bring nnvm::Tuple to mxnet::Tuple #14270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
changed the title
Bring nnvm::Tuple to mxnet::Tuple
[MXNET-1330] Bring nnvm::Tuple to mxnet::Tuple
Feb 27, 2019
Thanks for being willing to making so many micro-surgical changes scattered all over the places. |
reminisce
reviewed
Feb 27, 2019
reminisce
approved these changes
Feb 28, 2019
Hi, the CI has passed. Could someone kindly review and merge this PR if you have time? @szha @zheng-da @reminisce @eric-haibin-lin |
zheng-da
reviewed
Feb 28, 2019
zheng-da
approved these changes
Feb 28, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* Bring nnvm::Tuple to mxnet::Tuple * Retrigger CI * Fix issues casued by rebase * Address comments from Jun * Trigger CI * Address comments from Da * Retrigger due to flakiness * Retrigger CI
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Bring nnvm::Tuple to mxnet::Tuple * Retrigger CI * Fix issues casued by rebase * Address comments from Jun * Trigger CI * Address comments from Da * Retrigger due to flakiness * Retrigger CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the initial part of efforts for the numpy module of MXNet #14253, in which we bring nnvm's Tuple and TShape into MXNet for all further changes to happen locally in MXNet. See the section "Changes" for details.
Test coverage is ensured automatically ensured by our CI pipeline, because this PR is checked by all testcases related to any NDArray's shape.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments