This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[DO NOT REVIEW] Bring nnvm::Tuple to mxnet::Tuple #14217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add[Backend, pr-awaiting-review] |
marcoabreu
added
Backend
|
Most of the migration is done except for the PlanMemory pass, which blocked us from passing CI. |
|
Is it because PlanMemory expects |
junrushao
force-pushed
the
np-add-tshape
branch
from
02a6601
to
1ef2d4a
Compare
junrushao
force-pushed
the
np-add-tshape
branch
from
1ef2d4a
to
51228b4
Compare
|
Will send this to master's branch. So closing it for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a PR to master branch, so nothing will be affected.
This PR brought
nnvm::Tupleandnnvm::TShapeto mxnet, for future improvement of TShape.CC: @reminisce