-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix UUID check for existing tables without a UUID #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jzhuge FYI |
|
+1 LGTM A bit of context:
|
|
I think this PR would also resolve the problem when users upgraded to an Iceberg version that started assigning table UUIDs but their first operation wasn't a child of |
|
@rdblue, do we want to bring this in? There is only one open question on |
|
Yes, I just need to update it after your review. Sorry I'm taking so long getting back to it. |
355d9c0 to
4576866
Compare
|
@aokolnychyi, I updated |
aokolnychyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There is a relevant checkstyle violation. @rdblue, could you fix it and merge this PR?
|
Merged. Thanks for the review, @aokolnychyi! |
This fixes two cases when assigning UUIDs to tables without them: