Add table UUID #264
Merged
Add table UUID #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
reviewed
Jul 7, 2019
| taskOps.commit(base, updated); | ||
| // if the table UUID is missing, add it here. the UUID will be re-created each time this operation retries | ||
| // to ensure that if a concurrent operation assigns the UUID, this operation will not fail. | ||
| taskOps.commit(base, updated.withUUID()); |
Contributor
There was a problem hiding this comment.
Just to make sure I understand: table UUID isn't supposed to change once assigned and cannot be set back to null, right?
Contributor
Author
There was a problem hiding this comment.
Correct. This identifies a table so you can't start an operation, drop and recreate the table, and then complete the operation. We had it happen once.
Contributor
Author
|
Thanks for reviewing this, @aokolnychyi! I'm going to merge it. |
Fokko
added a commit
that referenced
this pull request
Aug 22, 2023
* Python: Support add column * Add integration tests (#264) * Python: Support add column * Add the requirement (#265) * Python: Support add column --------- Co-authored-by: Fokko Driesprong <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a UUID to table metadata that is randomly generated when new table metadata is created. Existing tables without a UUID will assign a UUID on a successful snapshot commit.