fix: base-ref/head-ref missed in dependency-review on master #2308
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,6 @@ name: "3rd-party" | |
| on: | ||
| push: | ||
| branches: | ||
| - /^release-.*$/ | ||
| pull_request: | ||
|
Comment on lines
3
to
7
There was a problem hiding this comment. Base-ref/head-ref are automatically assigned on pull_request, but are missing when pushing to master.
|
||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why need to remove it, since it is a triggering branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When pushing to the master branch, base-ref/head-ref isn't auto-assigned, leading to frequent errors. The reason for omitting it is that during PRs, we can directly check for unauthorized third-party libraries using 'Dependency Review' and decide whether to include them. There's no need to showcase this during master branch pushes.
Doc link 👇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get it, Thanks for the detailed description