fix: base-ref/head-ref missed in dependency-review on master #2308
Conversation
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| - /^release-.*$/ | ||
| pull_request: |
There was a problem hiding this comment.
Base-ref/head-ref are automatically assigned on pull_request, but are missing when pushing to master.
Doc link 👇
Codecov Report
@@ Coverage Diff @@
## master #2308 +/- ##
============================================
+ Coverage 65.06% 65.08% +0.01%
+ Complexity 981 979 -2
============================================
Files 498 498
Lines 41241 41241
Branches 5738 5738
============================================
+ Hits 26832 26840 +8
+ Misses 11750 11746 -4
+ Partials 2659 2655 -4 see 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -3,7 +3,6 @@ name: "3rd-party" | |||
| on: | |||
| push: | |||
| branches: | |||
| - master | |||
There was a problem hiding this comment.
I'm not sure why need to remove it, since it is a triggering branch
There was a problem hiding this comment.
I'm not sure why need to remove it, since it is a triggering branch
When pushing to the master branch, base-ref/head-ref isn't auto-assigned, leading to frequent errors. The reason for omitting it is that during PRs, we can directly check for unauthorized third-party libraries using 'Dependency Review' and decide whether to include them. There's no need to showcase this during master branch pushes.
There was a problem hiding this comment.
Get it, Thanks for the detailed description
| @@ -3,7 +3,6 @@ name: "3rd-party" | |||
| on: | |||
| push: | |||
| branches: | |||
| - master | |||
There was a problem hiding this comment.
Get it, Thanks for the detailed description
imbajin
changed the title
Purpose of the PR
fix: base-ref/head-ref miss in dependency-review on pushing to master
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need