Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Hide the interface of dependencies of GraphAr with PRIVATE link type #71

Merged
merged 9 commits into from
Jan 10, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Jan 10, 2023

Proposed changes

Fix the bug #70 with PRIVATE link type to build GraphAr library.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@acezen acezen requested a review from lixueclaire January 10, 2023 05:45
@acezen acezen changed the title Hide the interface of dependencies of GraphAr with PRIVATE link type [BugFix] Hide the interface of dependencies of GraphAr with PRIVATE link type Jan 10, 2023
@acezen acezen added bug Something isn't working bugfix and removed bug Something isn't working labels Jan 10, 2023
@acezen acezen force-pushed the 70-fix-target-link branch from cca0408 to d276c52 Compare January 10, 2023 07:07
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@acezen acezen merged commit 4b002a4 into apache:main Jan 10, 2023
@acezen acezen deleted the 70-fix-target-link branch January 10, 2023 09:17
@github-actions
Copy link

github-actions bot commented Jan 10, 2023

🎊 PR Preview 4b002a4 has been successfully built and deployed to https://alibaba-GraphAr-build-pr-71.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants