Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The libgar library building from source expose its interface to its dependencies #70

Closed
1 task done
acezen opened this issue Jan 10, 2023 · 1 comment
Closed
1 task done
Labels
bug Something isn't working

Comments

@acezen
Copy link
Contributor

acezen commented Jan 10, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When I use gar library in my project with

target_link_libraries(my_example PUBLIC ${GAR_LIBRARIES})

and build my project

got error:

-larrow_static not found

it looks like the target link libraries has inherited the gar library's dependency.
https://github.com/alibaba/GraphAr/blob/e8edfe38aa776f091dce24f4480fae06827194f4/CMakeLists.txt#L170-L172

Expected Behavior

DO NOT inherit the dependencies interface of GraphAr in user's project

Minimal Reproducible Example

project(MyExample)

find_package(gar REQUIRED)
include_directories(${GAR_INCLUDE_DIRS})

add_executable(my_example my_example.cc)
target_compile_features(my_example PRIVATE cxx_std_17)
target_link_libraries(my_example PRIVATE ${GAR_LIBRARIES})

Environment

  • Operating system: Ubuntu 20.04
  • GraphAr version: commit e8edfe3

Link to GraphAr Logs

No response

Further Information

No response

@acezen acezen added the bug Something isn't working label Jan 10, 2023
@acezen
Copy link
Contributor Author

acezen commented Jan 10, 2023

Solved by pull requets #71

@acezen acezen closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant