Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `include "arrow/api.h" from graph.h #50

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Dec 20, 2022

Proposed changes

The changes remove `include "arrow/api.h" from graph.h to avoid include any arrow header in GraphAr header files.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed issue #49

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update the API Reference before merging.

include/gar/graph.h Show resolved Hide resolved
@acezen acezen merged commit 08a654b into apache:main Dec 20, 2022
@acezen acezen deleted the 49-clean-arrow-header branch December 20, 2022 12:28
@acezen acezen added this to the Release 0.1.0 milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants