Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the arrow/api.h include from graph.h and move the related code to graph.cc #49

Closed
acezen opened this issue Dec 20, 2022 · 1 comment
Closed

Remove the arrow/api.h include from graph.h and move the related code to graph.cc #49

acezen opened this issue Dec 20, 2022 · 1 comment
Assignees
@acezen
Labels
improvement Improvement
Milestone
Release v0.1.0

Comments

@acezen
Copy link
Contributor

acezen commented Dec 20, 2022

Is your feature request related to a problem? Please describe.
To avoid include arrow's header in GraphAr headers, we need to remove the arrow/api.h include of graph.h and move the related code to graph.cc
@acezen acezen added the improvement Improvement label Dec 20, 2022
@acezen acezen self-assigned this Dec 20, 2022
@acezen acezen mentioned this issue Dec 20, 2022
Merged
9 tasks
@acezen acezen moved this to Done in alibaba/GraphAr Dec 21, 2022
@acezen acezen added this to the Release 0.1.0 milestone Dec 21, 2022
@acezen
Copy link
Contributor Author

acezen commented Dec 21, 2022

solved by #50

@acezen acezen closed this as completed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acezen acezen

Labels
improvement Improvement
Projects
None yet
Milestone
Release v0.1.0
Development

No branches or pull requests
1 participant
@acezen