Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][C++] Revise the ArrowChunkReader constructors by remove redundant parameter #360

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Feb 6, 2024

Proposed changes

see issue #359

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fix #359

@acezen acezen requested a review from lixueclaire February 6, 2024 09:10
@lixueclaire
Copy link
Contributor

I think the alternative solution is to use the method "seek_chunk_index" instead of "seek", could you please add a test case of using "seek_chunk_index"?

Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@acezen acezen merged commit 229021a into apache:main Feb 6, 2024
4 checks passed
@acezen acezen deleted the 359-remove-unrelated-parameter-from-arrow-chunk-reader branch February 6, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][C++] Make ArrowChunkReaders constructor parameter align to ChunkInfoReader
2 participants