Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][C++] Make ArrowChunkReaders constructor parameter align to ChunkInfoReader #359

Closed
acezen opened this issue Feb 6, 2024 · 0 comments · Fixed by #360
Closed
Assignees
Labels
enhancement New feature or request

Comments

@acezen
Copy link
Contributor

acezen commented Feb 6, 2024

Is your feature request related to a problem? Please describe.
In the original implementation of ArrowChunkReaders, the constructor's parameters are redundant, the vertex_chunk_index parameter should not be put in the constructor methods.

Describe the solution you'd like
remove the vertex_chunk_index parameter from the constructor methods, so the reader would start from vertex chunk 0 to read.
and when user want to read from certain vertex chunk, they should use the seek_chunk_index method to reset the vertex_chunk_index_

@acezen acezen added the enhancement New feature or request label Feb 6, 2024
@acezen acezen self-assigned this Feb 6, 2024
@acezen acezen changed the title [Improve][C++] Make ArrowChunkReaders construct parameter align to ChunkInfoReader [Improve][C++] Make ArrowChunkReaders constructor parameter align to ChunkInfoReader Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant