[1.4.x] Core: Expired Snapshot files in a transaction should be deleted #9223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che#9183) When a snapshot is expired as part of a transaction, the manifest list file(s) should be deleted when the transaction commits. A recent change (apache#6634) ensured that these files are not deleted when they have also been committed as part of a transaction, but this breaks the simple case where no new files are committed. Fix this by not skipping deletion when the list of committed files is empty. TESTING: Extended a unit test to ensure that manifest list files are deleted. Ran the test without the fix on a branch where apache#6634 was reverted to show that this is a regression.
Contributor
|
Thanks @bartash . I think let's get #9221 in first and then we can rebase this change? The change for returning a new empty set was not just stylistic, it was intentional to distinguish the case where deletion can be performed (empty snapshot list from expire snapshots in a transaction) and where deletion should not be performed if we could not determine the files to delete (snapshot lookup failed) |
Member
Author
|
Thanks @amogh-jahagirdar sounds good |
…tion when there are no new snapshots (apache#9221)
amogh-jahagirdar
approved these changes
Dec 6, 2023
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for taking this @bartash appreciate it!
nastra
changed the title
rdblue
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean cherry-pick of #9182 to 1.4.x
Closes #9182
cc @Fokko