Core: Fix logic in BaseTransaction for determining set of committed files when there are no new snapshots #9221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#9183 @bartash already added tests for the ExpireSnapshots case, but based on the tests passing before that implies there weren't any tests for case 2 above (since those would have caught the behavior change in deletion in case snapshots couldn't be looked up). It may be difficult to test for that case (have to force the lookup of a committed snapshot to be null right after the transaction commits) , but I'll look into it. |
amogh-jahagirdar
force-pushed
the
fix-committed-files
branch
from
02c33c4 to
0c2f0bf
Compare
amogh-jahagirdar
changed the title
amogh-jahagirdar
force-pushed
the
fix-committed-files
branch
from
0c2f0bf to
de56b30
Compare
amogh-jahagirdar
changed the title
bartash
approved these changes
Dec 5, 2023
Member
bartash
left a comment
bartash
left a comment
There was a problem hiding this comment.
Thanks for the improvement to my fix
rdblue
reviewed
Dec 5, 2023
…tion when there are no new snapshots
amogh-jahagirdar
force-pushed
the
fix-committed-files
branch
from
de56b30 to
a068c99
Compare
rdblue
approved these changes
Dec 5, 2023
bartash
pushed a commit
to bartash/iceberg
that referenced
this pull request
Dec 6, 2023
…tion when there are no new snapshots (apache#9221)
This was referenced Dec 11, 2023
amogh-jahagirdar
added a commit
that referenced
this pull request
Dec 19, 2023
…ed (#9223) * Core: Expired Snapshot files in a transaction should be deleted. (#9183) When a snapshot is expired as part of a transaction, the manifest list file(s) should be deleted when the transaction commits. A recent change (#6634) ensured that these files are not deleted when they have also been committed as part of a transaction, but this breaks the simple case where no new files are committed. Fix this by not skipping deletion when the list of committed files is empty. * Core: Fix logic for determining set of committed files in BaseTransaction when there are no new snapshots (#9221) --------- Co-authored-by: Amogh Jahagirdar <[email protected]>
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
…tion when there are no new snapshots (apache#9221)
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
…tion when there are no new snapshots (apache#9221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #9183. Null gets returned from
committedFilesin 2 cases:1.) The snapshot ID list is empty (e.g. ExpireSnapshots in a transaction). This snapshot ID is the set of snapshots produced as a result of the transaction
2.).The set of committed files could not exactly be determined (e.g. missing any snapshot metadata).
In the first case, the logic should perform file deletion in case there were no new snapshots (e.g. ExpireSnapshots) which #9183 pointed out and addressed.
In the second case, we do want to signal to callers that it's a unique situation and file deletions should not be performed.
What this change does is return an empty set in case 1 and null in case 2 to prevent deleting files when we could not determine the full set of committed files.