Spark: Backport fix NPE when create branch and tag on table without snapshot #7659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI seem to failed due to memory issue in https://github.com/apache/iceberg/actions/runs/5027176975/jobs/9016350188?pr=7659#step:6:232. close and reopen to retry it |
amogh-jahagirdar
approved these changes
May 19, 2023
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Looks good to me! thanks @dramaticlly!
Contributor
|
Merging since this is a clean backport |
Member
|
@dramaticlly are you working on a PR to back-port tag DDL? If not, I've already done it with Spark 3.1 in our own codebase and could contribute to the community. |
Contributor
Author
hey @manuzhang feel free to backport if you already done in your internal release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backport fix to Spark 3.1/3.2/3.3 of #7652
Also, I realized the
CreateOrReplaceTagExecdoes not exists in spark 3.1 and spark 3.2, will track the backport in a separate issue@amogh-jahagirdar