-
Notifications
You must be signed in to change notification settings - Fork 3k
Spark 3.4: Fix NPE when create branch and tag on table without snapshot #7652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this @dramaticlly
|
@amogh-jahagirdar Would be great to get this into 1.3.0 as well |
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dramaticlly just a comment on the exception message. Agree @Fokko woul be great to get this in!
...k/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestBranchDDL.java
Outdated
Show resolved
Hide resolved
...src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dramaticlly ! Will merge when CI completes
|
I think this fix is the same idea I had before #7593. But it doesn't matter, I am glad to see it was fixed. Thanks. closing my previous pr. |
This is based on apache#7097, and back-ports bug fixes apache#7652 and apache#8125
This is based on apache#7097, and back-ports bug fixes apache#7652 and apache#8086
This fix help throw proper validation exception instead of NullPointerException when create branch or tag on iceberg table without any snapshot.
Before
After
CC @amogh-jahagirdar @zhangbutao