Update documentation to reflect new catalog features #7433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramaticlly
force-pushed
the
SparkCatalogJavadoc
branch
2 times, most recently
from
ecda518 to
19259a6
Compare
dramaticlly
changed the title
Contributor
|
Could you also do it for Spark 3.4? |
Contributor
|
oh nvm about last comment, clicked the wrong link only showing the first commit. |
jackye1995
reviewed
Apr 26, 2023
jackye1995
reviewed
Apr 26, 2023
jackye1995
reviewed
Apr 26, 2023
Contributor
|
Looks like CI failed, could you check that? |
nastra
reviewed
Apr 26, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
mostly LGTM but would be could to simplify the diff
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 27, 2023
dramaticlly
force-pushed
the
SparkCatalogJavadoc
branch
from
f8eb404 to
56fd9e6
Compare
nastra
approved these changes
Apr 28, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
there were still a few unnecessary whitespace changes in the Table. Once those are fixed the changes LGTM
Co-authored-by: Eduard Tudenhoefner <[email protected]>
szehon-ho
reviewed
May 1, 2023
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
Looks great, just a few suggestions. Hope its not repeating any of the above comments
szehon-ho
approved these changes
May 3, 2023
Member
|
Merged, thanks @dramaticlly , @nastra @jackye1995 for review |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to include new features we developed over last few releases to be reflected in javadoc of SparkCatalog as it's lacking at the moment
CC @jackye1995 @Fokko @SinghAsDev @nastra